Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: luisgpm@linux.vnet.ibm.com, drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa, gdbserver] Fix breakage due to XML rework
Date: Fri, 04 Apr 2008 19:18:00 -0000	[thread overview]
Message-ID: <200804041909.m34J9opM025355@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <1207324826.19907.3.camel@gargoyle> from "Luis Machado" at Apr 04, 2008 01:00:25 PM

Hi Luis,

> This regressed two testcases for PowerPC (not sure if any other archs
> are affected), ext-run.exp and server-run.exp. This might have something
> to do with this message that shows up during the execution:
> 
> "Protocol error: qXfer:features:read (target-features) conflicting
> enabled responses."
> 
> Reverting the patch fixes the problem.

Doh.  If gdbserver always reports qXfer:features:read as supported,
it must of course also never return "unsupported" status when that
query is executed.  I thought this was already the case, but I 
overlooked this extra check ...   Sorry.

The following patch fixes the regressions on ppc.
OK for mainline?

Bye,
Ulrich


ChangeLog:

	* server.c (handle_query): Never return "unsupported" for
	qXfer:features:read queries.


diff -urNp gdb-orig/gdb/gdbserver/server.c gdb-head/gdb/gdbserver/server.c
--- gdb-orig/gdb/gdbserver/server.c	2008-03-27 14:11:52.000000000 +0100
+++ gdb-head/gdb/gdbserver/server.c	2008-04-04 20:39:26.703101250 +0200
@@ -497,14 +497,6 @@ handle_query (char *own_buf, int packet_
 
       require_running (own_buf);
 
-      /* Check for support.  */
-      document = get_features_xml ("target.xml");
-      if (document == NULL)
-	{
-	  own_buf[0] = '\0';
-	  return;
-	}
-
       /* Grab the annex, offset, and length.  */
       if (decode_xfer_read (own_buf + 20, &annex, &ofs, &len) < 0)
 	{


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-04-04 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  1:54 Ulrich Weigand
2008-03-27  2:02 ` Daniel Jacobowitz
2008-03-27 13:13   ` Ulrich Weigand
2008-04-04 17:32     ` Luis Machado
2008-04-04 19:18       ` Ulrich Weigand [this message]
2008-04-04 19:20         ` Daniel Jacobowitz
2008-04-04 19:48           ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804041909.m34J9opM025355@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox