From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5139 invoked by alias); 4 Apr 2008 19:10:16 -0000 Received: (qmail 5124 invoked by uid 22791); 4 Apr 2008 19:10:15 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Apr 2008 19:09:54 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id m34J9pWR126902 for ; Fri, 4 Apr 2008 19:09:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m34J9o2I4304918 for ; Fri, 4 Apr 2008 21:09:50 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m34J9oa7025358 for ; Fri, 4 Apr 2008 21:09:50 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m34J9opM025355; Fri, 4 Apr 2008 21:09:50 +0200 Message-Id: <200804041909.m34J9opM025355@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 4 Apr 2008 21:09:50 +0200 Subject: Re: [rfa, gdbserver] Fix breakage due to XML rework To: luisgpm@linux.vnet.ibm.com, drow@false.org Date: Fri, 04 Apr 2008 19:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1207324826.19907.3.camel@gargoyle> from "Luis Machado" at Apr 04, 2008 01:00:25 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00106.txt.bz2 Hi Luis, > This regressed two testcases for PowerPC (not sure if any other archs > are affected), ext-run.exp and server-run.exp. This might have something > to do with this message that shows up during the execution: > > "Protocol error: qXfer:features:read (target-features) conflicting > enabled responses." > > Reverting the patch fixes the problem. Doh. If gdbserver always reports qXfer:features:read as supported, it must of course also never return "unsupported" status when that query is executed. I thought this was already the case, but I overlooked this extra check ... Sorry. The following patch fixes the regressions on ppc. OK for mainline? Bye, Ulrich ChangeLog: * server.c (handle_query): Never return "unsupported" for qXfer:features:read queries. diff -urNp gdb-orig/gdb/gdbserver/server.c gdb-head/gdb/gdbserver/server.c --- gdb-orig/gdb/gdbserver/server.c 2008-03-27 14:11:52.000000000 +0100 +++ gdb-head/gdb/gdbserver/server.c 2008-04-04 20:39:26.703101250 +0200 @@ -497,14 +497,6 @@ handle_query (char *own_buf, int packet_ require_running (own_buf); - /* Check for support. */ - document = get_features_xml ("target.xml"); - if (document == NULL) - { - own_buf[0] = '\0'; - return; - } - /* Grab the annex, offset, and length. */ if (decode_xfer_read (own_buf + 20, &annex, &ofs, &len) < 0) { -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com