Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Carlos O'Donell <carlos@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Don't assume the name of Windows serial devices?
Date: Fri, 28 Mar 2008 14:45:00 -0000	[thread overview]
Message-ID: <20080328144521.GA18441@caradoc.them.org> (raw)
In-Reply-To: <47ED02B6.8010805@codesourcery.com>

On Fri, Mar 28, 2008 at 10:37:42AM -0400, Carlos O'Donell wrote:
>
> Is there any reason we restrict the Windows serial device names to "COM?" 
> A user could have serial boards, com ports higher than 9 (\\.\COMX), or 
> weird file devices that act like serial ports.
>
> The following patch removes the code that rejects devices that don't  
> start with the word "COM".
>
> Comments?

I don't think weird file devices will act enough like serial ports for
things to work just right, but I don't see the need for the
restriction either - hopefully no one tries to open random junk
with target remote :-)

> 2008-03-28  Carlos O'Donell  <carlos@codesourcery.com>
> 
> 	* ser-mingw.c (ser_windows_open): Open requested name.

OK.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-28 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28 14:38 Carlos O'Donell
2008-03-28 14:45 ` Daniel Jacobowitz [this message]
2008-03-28 17:33   ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080328144521.GA18441@caradoc.them.org \
    --to=drow@false.org \
    --cc=carlos@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox