From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13304 invoked by alias); 28 Mar 2008 14:45:45 -0000 Received: (qmail 13283 invoked by uid 22791); 28 Mar 2008 14:45:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Mar 2008 14:45:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0128C983AA; Fri, 28 Mar 2008 14:45:23 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id DB44A98060; Fri, 28 Mar 2008 14:45:22 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JfFpZ-0004oA-Ce; Fri, 28 Mar 2008 10:45:21 -0400 Date: Fri, 28 Mar 2008 14:45:00 -0000 From: Daniel Jacobowitz To: Carlos O'Donell Cc: gdb-patches Subject: Re: [RFC] Don't assume the name of Windows serial devices? Message-ID: <20080328144521.GA18441@caradoc.them.org> Mail-Followup-To: Carlos O'Donell , gdb-patches References: <47ED02B6.8010805@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47ED02B6.8010805@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00462.txt.bz2 On Fri, Mar 28, 2008 at 10:37:42AM -0400, Carlos O'Donell wrote: > > Is there any reason we restrict the Windows serial device names to "COM?" > A user could have serial boards, com ports higher than 9 (\\.\COMX), or > weird file devices that act like serial ports. > > The following patch removes the code that rejects devices that don't > start with the word "COM". > > Comments? I don't think weird file devices will act enough like serial ports for things to work just right, but I don't see the need for the restriction either - hopefully no one tries to open random junk with target remote :-) > 2008-03-28 Carlos O'Donell > > * ser-mingw.c (ser_windows_open): Open requested name. OK. -- Daniel Jacobowitz CodeSourcery