Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	gdb-patches@sourceware.org, 	Chet Ramey <chet.ramey@case.edu>
Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544)
Date: Mon, 24 Mar 2008 02:58:00 -0000	[thread overview]
Message-ID: <20080324025836.GA14474@caradoc.them.org> (raw)
In-Reply-To: <18406.61574.596374.828002@kahikatea.snap.net.nz>

On Mon, Mar 24, 2008 at 12:06:30PM +1200, Nick Roberts wrote:
>  > Anyway, since the patch is clearly at fault I have reverted it.
>  > Nick, Jan, thank you.
> 
> With this setting, for some reason this patch means that Gdb doesn't display
> the prompt but everything else gets displayed:

Thanks, that's very helpful.

What I think is happening is that rl_redisplay has some optimizations
which cause it not to redisplay.  And since we have a custom function
installed readline isn't calling the alternate hooks that force
display.  So rl_redisplay does not actually meet the interface
associated with rl_redisplay_function despite being its default
value.  Nasty.

We can work around that, probably by forcing redisplay and by
accepting slightly less optimized redraw, but it seems a bit lame...

We could patch our local readline with Jan's patch, which would fix it
for anyone using the included readline binary.  Or just KFAIL the test
until we merge a new readline version.  Thoughts?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-24  2:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 22:55 Jan Kratochvil
2008-03-18 23:18 ` Daniel Jacobowitz
2008-03-19  8:11   ` Jan Kratochvil
2008-03-19  8:46     ` Nick Roberts
2008-03-19  9:31       ` Jan Kratochvil
2008-03-19  9:56         ` Nick Roberts
2008-03-19 10:13           ` Jan Kratochvil
2008-03-21 20:45     ` Jan Kratochvil
2008-03-21 21:04       ` Daniel Jacobowitz
2008-03-21 21:45         ` Daniel Jacobowitz
2008-03-23 11:01           ` Nick Roberts
2008-03-23 16:30             ` Daniel Jacobowitz
2008-03-23 16:44               ` Jan Kratochvil
2008-03-23 17:30                 ` Daniel Jacobowitz
2008-03-24  0:07                   ` Nick Roberts
2008-03-24  2:58                     ` Daniel Jacobowitz [this message]
2008-03-24  7:42                       ` Jan Kratochvil
2008-03-24 12:00                         ` Daniel Jacobowitz
2008-03-24 13:03                           ` Jan Kratochvil
2008-03-24 13:27                             ` Daniel Jacobowitz
2008-03-25  1:02                       ` Chet Ramey
2008-03-25  2:53                         ` Daniel Jacobowitz
2008-03-25 15:56                           ` Chet Ramey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324025836.GA14474@caradoc.them.org \
    --to=drow@false.org \
    --cc=chet.ramey@case.edu \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox