From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21854 invoked by alias); 24 Mar 2008 02:58:59 -0000 Received: (qmail 21843 invoked by uid 22791); 24 Mar 2008 02:58:59 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 24 Mar 2008 02:58:39 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A6462983C6; Mon, 24 Mar 2008 02:58:37 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8183F982C4; Mon, 24 Mar 2008 02:58:37 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JdctQ-0003qi-Dp; Sun, 23 Mar 2008 22:58:36 -0400 Date: Mon, 24 Mar 2008 02:58:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Jan Kratochvil , gdb-patches@sourceware.org, Chet Ramey Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544) Message-ID: <20080324025836.GA14474@caradoc.them.org> Mail-Followup-To: Nick Roberts , Jan Kratochvil , gdb-patches@sourceware.org, Chet Ramey References: <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net> <20080321204506.GA5033@host0.dyn.jankratochvil.net> <20080321210323.GA30247@caradoc.them.org> <20080321214448.GB29593@caradoc.them.org> <18406.14411.437345.335844@kahikatea.snap.net.nz> <20080323163027.GB13603@caradoc.them.org> <20080323164331.GA1195@host0.dyn.jankratochvil.net> <20080323173015.GA17514@caradoc.them.org> <18406.61574.596374.828002@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18406.61574.596374.828002@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00347.txt.bz2 On Mon, Mar 24, 2008 at 12:06:30PM +1200, Nick Roberts wrote: > > Anyway, since the patch is clearly at fault I have reverted it. > > Nick, Jan, thank you. > > With this setting, for some reason this patch means that Gdb doesn't display > the prompt but everything else gets displayed: Thanks, that's very helpful. What I think is happening is that rl_redisplay has some optimizations which cause it not to redisplay. And since we have a custom function installed readline isn't calling the alternate hooks that force display. So rl_redisplay does not actually meet the interface associated with rl_redisplay_function despite being its default value. Nasty. We can work around that, probably by forcing redisplay and by accepting slightly less optimized redraw, but it seems a bit lame... We could patch our local readline with Jan's patch, which would fix it for anyone using the included readline binary. Or just KFAIL the test until we merge a new readline version. Thoughts? -- Daniel Jacobowitz CodeSourcery