From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] mips-tdep.c: Ignore use of sw after sd in prologue scanner
Date: Sat, 15 Mar 2008 03:00:00 -0000 [thread overview]
Message-ID: <20080315025956.GA29828@caradoc.them.org> (raw)
In-Reply-To: <20080314170325.090af32c@ironwood.lan>
On Fri, Mar 14, 2008 at 05:03:25PM -0700, Kevin Buettner wrote:
> On Thu, 6 Mar 2008 17:40:40 -0500
> Daniel Jacobowitz <drow@false.org> wrote:
>
> > Seems reasonable enough. Making it ABI-regsize-dependent would make
> > sense too.
>
> Thanks for looking it over.
>
> I decided that I liked the "ABI-regsize-dependent" approach better than
> my original patch. Here is what I've committed:
>
> * mips-tdep.c (mips32_scan_prologue): Use the ABI register size
> to decide whether to match instruction patterns using "sw" and "sd".
This version looks good to me too.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-03-15 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 22:13 Kevin Buettner
2008-03-06 22:41 ` Daniel Jacobowitz
2008-03-15 0:04 ` Kevin Buettner
2008-03-15 3:00 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080315025956.GA29828@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox