From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23717 invoked by alias); 15 Mar 2008 03:00:23 -0000 Received: (qmail 23688 invoked by uid 22791); 15 Mar 2008 03:00:20 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Mar 2008 03:00:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B8079983B5 for ; Sat, 15 Mar 2008 02:59:57 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 95679983AA for ; Sat, 15 Mar 2008 02:59:57 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JaMcm-0007nn-Cc for gdb-patches@sourceware.org; Fri, 14 Mar 2008 22:59:56 -0400 Date: Sat, 15 Mar 2008 03:00:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFC] mips-tdep.c: Ignore use of sw after sd in prologue scanner Message-ID: <20080315025956.GA29828@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20080306151249.122b91d3@ironwood.lan> <20080306224040.GA31830@caradoc.them.org> <20080314170325.090af32c@ironwood.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080314170325.090af32c@ironwood.lan> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00210.txt.bz2 On Fri, Mar 14, 2008 at 05:03:25PM -0700, Kevin Buettner wrote: > On Thu, 6 Mar 2008 17:40:40 -0500 > Daniel Jacobowitz wrote: > > > Seems reasonable enough. Making it ABI-regsize-dependent would make > > sense too. > > Thanks for looking it over. > > I decided that I liked the "ABI-regsize-dependent" approach better than > my original patch. Here is what I've committed: > > * mips-tdep.c (mips32_scan_prologue): Use the ABI register size > to decide whether to match instruction patterns using "sw" and "sd". This version looks good to me too. -- Daniel Jacobowitz CodeSourcery