Re: [RFA] Keep breakpoints always inserted.

[Vladimir Prus <vladimir@codesourcery.com>]

On Tuesday 11 March 2008 00:08:44 Daniel Jacobowitz wrote:
> On Thu, Feb 28, 2008 at 05:17:13PM +0300, Vladimir Prus wrote:
> > 
> > This is hopefully final revision of my patch to keep
> > breakpoints always inserted, which is needed to support
> > non-stop mode. A new variable 'breakpoint always-inserted'
> > is introduced that enables this mode.  When enabled,
> > breakpoints are inserted into target immediately when created,
> > and they are not removed when we stop.
> > 
> > Compared to the previous version of this patch:
> > - The always-inserted mode is actually configurable
> > - In always-inserted mode, breakpoints are removed
> > from target on detach/disconnect.
> > 
> > OK?
> 
> This patch is OK, if you will add the missing pieces: a NEWS entry and
> documentation for the new command, and a testcase that enables
> always-inserted and verifies that it isn't a brick.

Hmm. I think the ideally, we'd run entire testsuite with this
mode enabled -- there are various corner cases. But then, we might
regress the not-always-inserted-breakpoints mode. Although the
potential for breakage is higher for always-inserted mode. I really
don't know how to ensure good coverage for both.

- Volodya