From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15481 invoked by alias); 14 Mar 2008 20:22:16 -0000 Received: (qmail 15471 invoked by uid 22791); 14 Mar 2008 20:22:15 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 20:21:58 +0000 Received: (qmail 23701 invoked from network); 14 Mar 2008 20:21:54 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2008 20:21:54 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: [RFA] Keep breakpoints always inserted. Date: Fri, 14 Mar 2008 20:22:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200802281717.14766.vladimir@codesourcery.com> <20080310210844.GB14908@caradoc.them.org> In-Reply-To: <20080310210844.GB14908@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803142322.04240.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00199.txt.bz2 On Tuesday 11 March 2008 00:08:44 Daniel Jacobowitz wrote: > On Thu, Feb 28, 2008 at 05:17:13PM +0300, Vladimir Prus wrote: > > > > This is hopefully final revision of my patch to keep > > breakpoints always inserted, which is needed to support > > non-stop mode. A new variable 'breakpoint always-inserted' > > is introduced that enables this mode. When enabled, > > breakpoints are inserted into target immediately when created, > > and they are not removed when we stop. > > > > Compared to the previous version of this patch: > > - The always-inserted mode is actually configurable > > - In always-inserted mode, breakpoints are removed > > from target on detach/disconnect. > > > > OK? > > This patch is OK, if you will add the missing pieces: a NEWS entry and > documentation for the new command, and a testcase that enables > always-inserted and verifies that it isn't a brick. Hmm. I think the ideally, we'd run entire testsuite with this mode enabled -- there are various corner cases. But then, we might regress the not-always-inserted-breakpoints mode. Although the potential for breakage is higher for always-inserted mode. I really don't know how to ensure good coverage for both. - Volodya