* [RFA] Remove unused remote.c hooks.
@ 2008-03-13 19:06 Vladimir Prus
2008-03-13 19:37 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Prus @ 2008-03-13 19:06 UTC (permalink / raw)
To: gdb-patches
This patch removes some code that's apparently no
longer used anywhere in GDB. OK?
- Volodya
* remote.c (deprecated_target_resume_hook)
(deprecated_target_wait_loop_hook): Remove.
(remote_resume): Do not call deprecated_target_resume_hook.
(remote_wait): Do not call deprecated_target_wait_loop_hook.
(remote_async_wait): Likewise.
---
gdb/remote.c | 20 --------------------
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 56c7f5c..73fcc2a 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -1037,11 +1037,6 @@ static int use_threadextra_query;
static struct async_signal_handler *sigint_remote_twice_token;
static struct async_signal_handler *sigint_remote_token;
-/* These are pointers to hook functions that may be set in order to
- modify resume/wait behavior for a particular architecture. */
-
-void (*deprecated_target_resume_hook) (void);
-void (*deprecated_target_wait_loop_hook) (void);
\f
@@ -3096,11 +3091,6 @@ remote_resume (ptid_t ptid, int step, enum target_signal siggnal)
last_sent_signal = siggnal;
last_sent_step = step;
- /* A hook for when we need to do something at the last moment before
- resumption. */
- if (deprecated_target_resume_hook)
- (*deprecated_target_resume_hook) ();
-
/* Update the inferior on signals to silently pass, if they've changed. */
remote_pass_signals ();
@@ -3376,11 +3366,6 @@ remote_wait (ptid_t ptid, struct target_waitstatus *status)
buf = rs->buf;
- /* This is a hook for when we need to do something (perhaps the
- collection of trace data) every time the target stops. */
- if (deprecated_target_wait_loop_hook)
- (*deprecated_target_wait_loop_hook) ();
-
remote_stopped_by_watchpoint_p = 0;
switch (buf[0])
@@ -3610,11 +3595,6 @@ remote_async_wait (ptid_t ptid, struct target_waitstatus *status)
buf = rs->buf;
- /* This is a hook for when we need to do something (perhaps the
- collection of trace data) every time the target stops. */
- if (deprecated_target_wait_loop_hook)
- (*deprecated_target_wait_loop_hook) ();
-
switch (buf[0])
{
case 'E': /* Error of some sort. */
--
1.5.3.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFA] Remove unused remote.c hooks.
2008-03-13 19:06 [RFA] Remove unused remote.c hooks Vladimir Prus
@ 2008-03-13 19:37 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-03-13 19:37 UTC (permalink / raw)
To: Vladimir Prus; +Cc: gdb-patches
On Thu, Mar 13, 2008 at 10:04:51PM +0300, Vladimir Prus wrote:
>
> This patch removes some code that's apparently no
> longer used anywhere in GDB. OK?
>
> - Volodya
>
> * remote.c (deprecated_target_resume_hook)
> (deprecated_target_wait_loop_hook): Remove.
> (remote_resume): Do not call deprecated_target_resume_hook.
> (remote_wait): Do not call deprecated_target_wait_loop_hook.
> (remote_async_wait): Likewise.
OK, thanks! Glad to see this disappear.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-13 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-13 19:06 [RFA] Remove unused remote.c hooks Vladimir Prus
2008-03-13 19:37 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox