From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/RFC] Fix broken user-thread debugging on x86-solaris
Date: Wed, 12 Mar 2008 18:05:00 -0000 [thread overview]
Message-ID: <20080312180445.GC3738@adacore.com> (raw)
In-Reply-To: <20080312172129.GA25188@caradoc.them.org>
> > In this version, I went to the simplest, which is to have configure
> > define a new macro (HAVE_X86_SOLARIS_USER_THREADS) when on x86-solaris
> > and the thread_db library is available. I then replaced TM_I386SOL2_H
> > by the new macro.
>
> How about just #if defined(__i386__) || defined(__x86_64__), if we're
> going to use macros?
I don't mind, but we also need to check for solaris too, since
procfs is used with other OSes as well. So something like this?
#if (defined(__i386__) || defined(__x86_64__)) && defined (sun)
It's funny you would prefer this approach over the more functional
macro - I thought that people would crucify me if I suggested something
like this :). Would you prefer to isolate the code in a separate file
like I also suggested?
--
Joel
next prev parent reply other threads:[~2008-03-12 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 17:08 Joel Brobecker
2008-03-12 17:22 ` Daniel Jacobowitz
2008-03-12 18:05 ` Joel Brobecker [this message]
2008-03-12 18:13 ` Daniel Jacobowitz
2008-03-12 20:08 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080312180445.GC3738@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox