From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10892 invoked by alias); 12 Mar 2008 18:05:07 -0000 Received: (qmail 10884 invoked by uid 22791); 12 Mar 2008 18:05:07 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Mar 2008 18:04:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E71F02AA5EC for ; Wed, 12 Mar 2008 14:04:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q7R3n6MOuni8 for ; Wed, 12 Mar 2008 14:04:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A66822AA22B for ; Wed, 12 Mar 2008 14:04:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 71BDFE7ACB; Wed, 12 Mar 2008 11:04:45 -0700 (PDT) Date: Wed, 12 Mar 2008 18:05:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/RFC] Fix broken user-thread debugging on x86-solaris Message-ID: <20080312180445.GC3738@adacore.com> References: <20080312170814.GC4433@adacore.com> <20080312172129.GA25188@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080312172129.GA25188@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00130.txt.bz2 > > In this version, I went to the simplest, which is to have configure > > define a new macro (HAVE_X86_SOLARIS_USER_THREADS) when on x86-solaris > > and the thread_db library is available. I then replaced TM_I386SOL2_H > > by the new macro. > > How about just #if defined(__i386__) || defined(__x86_64__), if we're > going to use macros? I don't mind, but we also need to check for solaris too, since procfs is used with other OSes as well. So something like this? #if (defined(__i386__) || defined(__x86_64__)) && defined (sun) It's funny you would prefer this approach over the more functional macro - I thought that people would crucify me if I suggested something like this :). Would you prefer to isolate the code in a separate file like I also suggested? -- Joel