Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: hidetaka.takano@glb.toshiba.co.jp (Hidetaka Takano)
Cc: gdb-patches@sourceware.org
Subject: Re: problem with "info spu signal" command on spu-gdb
Date: Mon, 10 Mar 2008 12:40:00 -0000	[thread overview]
Message-ID: <200803101240.m2ACeNbd005664@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <002501c87f83$e0942e30$f61e4f9d@MOSTPCMSS20377> from "Hidetaka Takano" at Mar 06, 2008 09:16:16 PM

Hello Takano-san,

just some minor formatting nits:

> 2008-02-29  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>

There should be two spaces between the name and the e-mail address.

> 	* spu-tdep.c (info_spu_event_command): insert a '\0' to the end
> 	of the data passing to strtoulst function.

Start the sentence describing the change with a capital letter.

> 	* spu-tdep.c (info_spu_signal_command): Likewise.

For multiple changes to the same file, it suffices to name the
file only once.

I've made those changes and committed the patch; here's the
version of the ChangeLog entry I committed:

2008-03-10  Hidetaka Takano  <hidetaka.takano@glb.toshiba.co.jp>

	* spu-tdep.c (info_spu_event_command): Insert a '\0' to the end
	of the data passing to strtoulst function.
	(info_spu_signal_command): Likewise.

Thanks for fixing this problem!

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2008-03-10 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 13:48 Hidetaka Takano
2008-03-03 14:28 ` Ulrich Weigand
2008-03-06 12:17   ` Hidetaka Takano
2008-03-10 12:40     ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803101240.m2ACeNbd005664@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hidetaka.takano@glb.toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox