From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21301 invoked by alias); 10 Mar 2008 12:40:54 -0000 Received: (qmail 21282 invoked by uid 22791); 10 Mar 2008 12:40:48 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 12:40:26 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2ACeOo3100710 for ; Mon, 10 Mar 2008 12:40:24 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2ACeNlv1679486 for ; Mon, 10 Mar 2008 13:40:23 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2ACeN0f005669 for ; Mon, 10 Mar 2008 13:40:23 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m2ACeNbd005664; Mon, 10 Mar 2008 13:40:23 +0100 Message-Id: <200803101240.m2ACeNbd005664@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 10 Mar 2008 13:40:23 +0100 Subject: Re: problem with "info spu signal" command on spu-gdb To: hidetaka.takano@glb.toshiba.co.jp (Hidetaka Takano) Date: Mon, 10 Mar 2008 12:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <002501c87f83$e0942e30$f61e4f9d@MOSTPCMSS20377> from "Hidetaka Takano" at Mar 06, 2008 09:16:16 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00094.txt.bz2 Hello Takano-san, just some minor formatting nits: > 2008-02-29 Hidetaka Takano There should be two spaces between the name and the e-mail address. > * spu-tdep.c (info_spu_event_command): insert a '\0' to the end > of the data passing to strtoulst function. Start the sentence describing the change with a capital letter. > * spu-tdep.c (info_spu_signal_command): Likewise. For multiple changes to the same file, it suffices to name the file only once. I've made those changes and committed the patch; here's the version of the ChangeLog entry I committed: 2008-03-10 Hidetaka Takano * spu-tdep.c (info_spu_event_command): Insert a '\0' to the end of the data passing to strtoulst function. (info_spu_signal_command): Likewise. Thanks for fixing this problem! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com