From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@specifix.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] compilation error in remote.c on sparc-solaris
Date: Fri, 07 Mar 2008 19:02:00 -0000 [thread overview]
Message-ID: <20080307190151.GA32333@caradoc.them.org> (raw)
In-Reply-To: <1204916101.19253.715.camel@localhost.localdomain>
On Fri, Mar 07, 2008 at 10:55:01AM -0800, Michael Snyder wrote:
> > Variable pid is defined as follow:
> >
> > pid_t pid;
> >
> > I think it's good enough to change its type to "int". I've never seen
> > a PID that's larger than 7 digits, so an int should always be big enough.
> > In any case, that's what the pid_t structure uses for the pid.
>
> Why not just cast it?
Because it's not a pid_t, it's an int. pid_t is the type of a process
on the host system and we're not talking to any host system processes
here.
> > 2008-03-07 Joel Brobecker <brobecker@adacore.com>
> >
> > * remote.c (extended_remote_attach_1): Make local variable pid an int
> > instead of a pid_t.
This is OK - thanks, Joel, I'd been meaning to fix this since we
noticed it :-( I can't find the number, but I'm pretty sure there's
a PR in gnats too.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-03-07 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 18:28 Joel Brobecker
2008-03-07 18:55 ` Michael Snyder
2008-03-07 19:02 ` Daniel Jacobowitz [this message]
2008-03-07 19:15 ` Michael Snyder
2008-03-07 19:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080307190151.GA32333@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@specifix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox