From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11686 invoked by alias); 7 Mar 2008 19:02:26 -0000 Received: (qmail 11675 invoked by uid 22791); 7 Mar 2008 19:02:25 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Mar 2008 19:01:55 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 453D1983A0; Fri, 7 Mar 2008 19:01:53 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F3BB298149; Fri, 7 Mar 2008 19:01:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JXhpH-0008QJ-S5; Fri, 07 Mar 2008 14:01:51 -0500 Date: Fri, 07 Mar 2008 19:02:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA] compilation error in remote.c on sparc-solaris Message-ID: <20080307190151.GA32333@caradoc.them.org> Mail-Followup-To: Michael Snyder , Joel Brobecker , gdb-patches@sourceware.org References: <20080307182744.GG3995@adacore.com> <1204916101.19253.715.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1204916101.19253.715.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00053.txt.bz2 On Fri, Mar 07, 2008 at 10:55:01AM -0800, Michael Snyder wrote: > > Variable pid is defined as follow: > > > > pid_t pid; > > > > I think it's good enough to change its type to "int". I've never seen > > a PID that's larger than 7 digits, so an int should always be big enough. > > In any case, that's what the pid_t structure uses for the pid. > > Why not just cast it? Because it's not a pid_t, it's an int. pid_t is the type of a process on the host system and we're not talking to any host system processes here. > > 2008-03-07 Joel Brobecker > > > > * remote.c (extended_remote_attach_1): Make local variable pid an int > > instead of a pid_t. This is OK - thanks, Joel, I'd been meaning to fix this since we noticed it :-( I can't find the number, but I'm pretty sure there's a PR in gnats too. -- Daniel Jacobowitz CodeSourcery