From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Unbreak 'target async'.
Date: Sun, 24 Feb 2008 14:51:00 -0000 [thread overview]
Message-ID: <20080223184653.GA16857@caradoc.them.org> (raw)
In-Reply-To: <200802232130.56913.vladimir@codesourcery.com>
On Sat, Feb 23, 2008 at 09:30:56PM +0300, Vladimir Prus wrote:
>
> Presently, if I connect to gdbserver using 'target async'
> and then to 'continue', then continue never finishes.
> What happens is that serial_async first calls scb->ops->async,
> and only then sets scb->async_handler.
> However, ser_base_async calls reschedule which calls serial_is_async,
> which checks scb->async_handler. Since it's not set yet,
> async mode is never enabled.
>
> The below patch allows me to do 'continue' successfully.
> I did not run the testsuite, since it's apparent that
> this patch cannot break "target async" more that it's broken now.
> OK?
OK.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-02-23 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 18:47 Vladimir Prus
2008-02-24 14:51 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223184653.GA16857@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox