From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5763 invoked by alias); 23 Feb 2008 18:47:17 -0000 Received: (qmail 5732 invoked by uid 22791); 23 Feb 2008 18:47:15 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 23 Feb 2008 18:46:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2224498036; Sat, 23 Feb 2008 18:46:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F1CF098005; Sat, 23 Feb 2008 18:46:53 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JSzOf-0004W7-6a; Sat, 23 Feb 2008 13:46:53 -0500 Date: Sun, 24 Feb 2008 14:51:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Unbreak 'target async'. Message-ID: <20080223184653.GA16857@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200802232130.56913.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802232130.56913.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00365.txt.bz2 On Sat, Feb 23, 2008 at 09:30:56PM +0300, Vladimir Prus wrote: > > Presently, if I connect to gdbserver using 'target async' > and then to 'continue', then continue never finishes. > What happens is that serial_async first calls scb->ops->async, > and only then sets scb->async_handler. > However, ser_base_async calls reschedule which calls serial_is_async, > which checks scb->async_handler. Since it's not set yet, > async mode is never enabled. > > The below patch allows me to do 'continue' successfully. > I did not run the testsuite, since it's apparent that > this patch cannot break "target async" more that it's broken now. > OK? OK. -- Daniel Jacobowitz CodeSourcery