From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfa/solib] Always reload DT_DEBUG, trust r_brk
Date: Thu, 21 Feb 2008 01:47:00 -0000 [thread overview]
Message-ID: <20080221014732.GA27568@caradoc.them.org> (raw)
In-Reply-To: <20080220170844.243d3b8e@ironwood.lan>
On Wed, Feb 20, 2008 at 05:08:44PM -0700, Kevin Buettner wrote:
> > 2008-02-08 Daniel Jacobowitz <dan@codesourcery.com>
> >
> > * mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Set
> > r_brk_offset.
> > (mipsnbsd_lp64_fetch_link_map_offsets): Likewise.
> > * solib-svr4.c (solib_svr4_r_brk): New.
> > (open_symbol_file_object, svr4_current_sos): Always check the
> > debug base.
> > (svr4_fetch_objfile_link_map): Do not set debug_base.
> > (enable_break): Use r_brk if it is set.
> > (svr4_ilp32_fetch_link_map_offsets): Set r_brk_offset.
> > (svr4_lp64_fetch_link_map_offsets): Likewise.
> > * solib-svr4.h (struct link_map_offsets): Add r_brk_offset.
>
> These changes look reasonable to me. Go ahead and commit them.
Thanks! I've done so.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-02-21 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 19:11 Daniel Jacobowitz
2008-02-21 0:09 ` Kevin Buettner
2008-02-21 1:47 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221014732.GA27568@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox