From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19115 invoked by alias); 21 Feb 2008 01:47:55 -0000 Received: (qmail 19100 invoked by uid 22791); 21 Feb 2008 01:47:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Feb 2008 01:47:35 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CB1589802E for ; Thu, 21 Feb 2008 01:47:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id AD55A9802B for ; Thu, 21 Feb 2008 01:47:33 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JS0X6-0007BR-VC for gdb-patches@sourceware.org; Wed, 20 Feb 2008 20:47:32 -0500 Date: Thu, 21 Feb 2008 01:47:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfa/solib] Always reload DT_DEBUG, trust r_brk Message-ID: <20080221014732.GA27568@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20080208191111.GA30569@caradoc.them.org> <20080220170844.243d3b8e@ironwood.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080220170844.243d3b8e@ironwood.lan> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00343.txt.bz2 On Wed, Feb 20, 2008 at 05:08:44PM -0700, Kevin Buettner wrote: > > 2008-02-08 Daniel Jacobowitz > > > > * mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets): Set > > r_brk_offset. > > (mipsnbsd_lp64_fetch_link_map_offsets): Likewise. > > * solib-svr4.c (solib_svr4_r_brk): New. > > (open_symbol_file_object, svr4_current_sos): Always check the > > debug base. > > (svr4_fetch_objfile_link_map): Do not set debug_base. > > (enable_break): Use r_brk if it is set. > > (svr4_ilp32_fetch_link_map_offsets): Set r_brk_offset. > > (svr4_lp64_fetch_link_map_offsets): Likewise. > > * solib-svr4.h (struct link_map_offsets): Add r_brk_offset. > > These changes look reasonable to me. Go ahead and commit them. Thanks! I've done so. -- Daniel Jacobowitz CodeSourcery