From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc]: Replace current_gdbarch in hppa
Date: Fri, 15 Feb 2008 20:19:00 -0000 [thread overview]
Message-ID: <200802152019.45868.pedro@codesourcery.com> (raw)
In-Reply-To: <200802151838.m1FIcnFC028614@d12av02.megacenter.de.ibm.com>
A Friday 15 February 2008 18:38:49, Ulrich Weigand wrote:
> This is really the wrong check. It should really just verify that
> no out-of-bounds access to u_offsets happens, so the line should
> just be something like:
>
> if ((unsigned) regno >= ARRAY_SIZE (u_offsets))
(Just wondering, since these things have been discussed before.)
Can any user input lead to such a stray regno? Or are all
those off accesses really GDB bugs? If so, why not make
it a gdb_assert or internal_error?
--
Pedro Alves
next prev parent reply other threads:[~2008-02-15 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 6:48 Markus Deuling
2008-02-15 18:39 ` Ulrich Weigand
2008-02-15 20:19 ` Pedro Alves [this message]
2008-02-15 20:22 ` Daniel Jacobowitz
2008-02-18 14:28 ` Markus Deuling
2008-02-18 14:37 ` Ulrich Weigand
2008-02-18 14:47 ` Markus Deuling
2008-02-18 16:04 ` Ulrich Weigand
2008-02-18 16:12 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802152019.45868.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox