From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18567 invoked by alias); 15 Feb 2008 20:19:57 -0000 Received: (qmail 18519 invoked by uid 22791); 15 Feb 2008 20:19:57 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Feb 2008 20:19:39 +0000 Received: (qmail 12472 invoked from network); 15 Feb 2008 20:19:37 -0000 Received: from unknown (HELO pedro-laptop-dell) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Feb 2008 20:19:37 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [rfc]: Replace current_gdbarch in hppa Date: Fri, 15 Feb 2008 20:19:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) References: <200802151838.m1FIcnFC028614@d12av02.megacenter.de.ibm.com> In-Reply-To: <200802151838.m1FIcnFC028614@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200802152019.45868.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00264.txt.bz2 A Friday 15 February 2008 18:38:49, Ulrich Weigand wrote: > This is really the wrong check. =A0It should really just verify that > no out-of-bounds access to u_offsets happens, so the line should > just be something like: > > =A0 =A0if ((unsigned) regno >=3D ARRAY_SIZE (u_offsets)) (Just wondering, since these things have been discussed before.) Can any user input lead to such a stray regno? Or are all those off accesses really GDB bugs? If so, why not make it a gdb_assert or internal_error? --=20 Pedro Alves