Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc]: Replace current_gdbarch in sentinel-frame.c
Date: Fri, 15 Feb 2008 17:44:00 -0000	[thread overview]
Message-ID: <200802151743.m1FHhsnE027334@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <47B55A49.2040107@de.ibm.com> from "Markus Deuling" at Feb 15, 2008 10:24:25 AM

Markus Deuling wrote:

> @@ -54,7 +54,7 @@ sentinel_frame_prev_register (struct fra
>       onto the corresponding hardware register.  */
>    *optimized = 0;
>    *lvalp = lval_register;
> -  *addrp = register_offset_hack (current_gdbarch, regnum);
> +  *addrp = register_offset_hack (get_frame_arch (next_frame), regnum);
>    *realnum = regnum;

This is not OK -- as the sentinel frame is always the innermost
frame, next_frame will always be NULL here.

You could use the gdbarch of the sentinel frame's regcache
(cache->regcache).

However, I think setting the "address" for register values is
no longer needed anymore, so the whole call to register_offset_hack
(and the function itself) can be removed.

Can you try whether simply setting *addrp = 0 works?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2008-02-15 17:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15  9:27 Markus Deuling
2008-02-15 17:44 ` Michael Snyder
2008-02-15 17:51   ` Michael Snyder
2008-02-15 17:44 ` Ulrich Weigand [this message]
2008-02-15 18:40   ` Thiago Jung Bauermann
2008-02-15 18:59     ` Ulrich Weigand
2008-02-18 15:28       ` Markus Deuling
2008-02-18 16:05         ` Ulrich Weigand
2008-02-18 16:38           ` Markus Deuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802151743.m1FHhsnE027334@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox