Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@specifix.com>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc]: Replace current_gdbarch in sentinel-frame.c
Date: Fri, 15 Feb 2008 17:51:00 -0000	[thread overview]
Message-ID: <1203097872.19253.130.camel@localhost.localdomain> (raw)
In-Reply-To: <1203097447.19253.128.camel@localhost.localdomain>

On Fri, 2008-02-15 at 09:44 -0800, Michael Snyder wrote:
> On Fri, 2008-02-15 at 10:24 +0100, Markus Deuling wrote:
> > Hi,
> > 
> > this is a trivial replacement of current_gdbarch in sentinel-frame.c. Tested on x86.
> > 
> > Ok to commit?
> 
> Looks fine to me.

And it seems I was premature.
I defer to Ulrich.   ;-)

> 
> > 
> > 
> > ChangeLog:
> > 
> > 	* sentinel-frame.c (sentinel_frame_prev_register): Use get_frame_arch
> > 	to get at the current architecture.
> > 
> > Regards, 
> > Markus
> > 
> > 
> > plain text document attachment (diff-sentinel)
> > diff -urpN src/gdb/sentinel-frame.c dev/gdb/sentinel-frame.c
> > --- src/gdb/sentinel-frame.c	2008-01-01 23:53:12.000000000 +0100
> > +++ dev/gdb/sentinel-frame.c	2008-02-15 10:07:36.000000000 +0100
> > @@ -54,7 +54,7 @@ sentinel_frame_prev_register (struct fra
> >       onto the corresponding hardware register.  */
> >    *optimized = 0;
> >    *lvalp = lval_register;
> > -  *addrp = register_offset_hack (current_gdbarch, regnum);
> > +  *addrp = register_offset_hack (get_frame_arch (next_frame), regnum);
> >    *realnum = regnum;
> >  
> >    /* If needed, find and return the value of the register.  */
> 


  reply	other threads:[~2008-02-15 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15  9:27 Markus Deuling
2008-02-15 17:44 ` Michael Snyder
2008-02-15 17:51   ` Michael Snyder [this message]
2008-02-15 17:44 ` Ulrich Weigand
2008-02-15 18:40   ` Thiago Jung Bauermann
2008-02-15 18:59     ` Ulrich Weigand
2008-02-18 15:28       ` Markus Deuling
2008-02-18 16:05         ` Ulrich Weigand
2008-02-18 16:38           ` Markus Deuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203097872.19253.130.camel@localhost.localdomain \
    --to=msnyder@specifix.com \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox