From: Daniel Jacobowitz <drow@false.org>
To: Yakov Lerner <iler.ml@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: fix compilation error under gcc 3.2.3 (warning treated as error)
Date: Thu, 14 Feb 2008 16:48:00 -0000 [thread overview]
Message-ID: <20080214164817.GA2581@caradoc.them.org> (raw)
In-Reply-To: <f36b08ee0802132337p2a1e7992i535cb3ac80f32c4b@mail.gmail.com>
On Thu, Feb 14, 2008 at 09:37:26AM +0200, Yakov Lerner wrote:
> Fix "duplicate const" compilation error (warning treated as error)
> under gcc 3.2.3 (AS3 Linux, gcc version 3.2.3 20030502 (Red Hat Linux
> 3.2.3-20)).
>
> Typedef for reloc_howto_type already has const, remove
> unnecessary const at line 1174 bfd/elf32-i386.c
Your patch adds const, not removes it - I think you diffed files in
the wrong order.
Also, this change is already in GDB HEAD. It's helpful if you can
work from HEAD if you submit patches, or at least say what version
you were working from.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-02-14 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 7:37 Yakov Lerner
2008-02-14 16:48 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214164817.GA2581@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=iler.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox