From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11163 invoked by alias); 14 Feb 2008 16:48:49 -0000 Received: (qmail 11154 invoked by uid 22791); 14 Feb 2008 16:48:49 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Feb 2008 16:48:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9A26498140; Thu, 14 Feb 2008 16:48:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 746F79811F; Thu, 14 Feb 2008 16:48:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1JPhFx-0000gD-Ly; Thu, 14 Feb 2008 11:48:17 -0500 Date: Thu, 14 Feb 2008 16:48:00 -0000 From: Daniel Jacobowitz To: Yakov Lerner Cc: gdb-patches@sourceware.org Subject: Re: fix compilation error under gcc 3.2.3 (warning treated as error) Message-ID: <20080214164817.GA2581@caradoc.them.org> Mail-Followup-To: Yakov Lerner , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00231.txt.bz2 On Thu, Feb 14, 2008 at 09:37:26AM +0200, Yakov Lerner wrote: > Fix "duplicate const" compilation error (warning treated as error) > under gcc 3.2.3 (AS3 Linux, gcc version 3.2.3 20030502 (Red Hat Linux > 3.2.3-20)). > > Typedef for reloc_howto_type already has const, remove > unnecessary const at line 1174 bfd/elf32-i386.c Your patch adds const, not removes it - I think you diffed files in the wrong order. Also, this change is already in GDB HEAD. It's helpful if you can work from HEAD if you submit patches, or at least say what version you were working from. -- Daniel Jacobowitz CodeSourcery