From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [BUG] BINOP_DIV and ptyp command
Date: Tue, 29 Jan 2008 14:42:00 -0000 [thread overview]
Message-ID: <20080129134609.GB22342@caradoc.them.org> (raw)
In-Reply-To: <e394668d0801282134q1205260cg589bfd8a0b3ddc1a@mail.gmail.com>
On Mon, Jan 28, 2008 at 09:34:48PM -0800, Doug Evans wrote:
> On Jan 28, 2008 8:52 PM, Doug Evans <dje@google.com> wrote:
> > [...]
> > So it seems like the following is the correct patch.
>
> Well, not quite. Ok to check the appended patch in?
>
> Changing the expected result to long makes / and % no longer special -
> x*y has an expected result of long.
>
> One can argue it should be int, but any fix for that is orthogonal to
> fixing / and % handling. I think.
If you had to change a testcase to a more wrong answer, then the bug
isn't orthogonal :-) We should be following C promotion rules, and
automatically promoting int math to long is incorrect.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-29 13:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <002301c85c12$a73a4640$f5aed2c0$@u-strasbg.fr>
2008-01-29 5:26 ` Doug Evans
2008-01-29 6:32 ` Doug Evans
2008-01-29 14:42 ` Daniel Jacobowitz [this message]
2008-01-29 16:16 ` Doug Evans
2008-01-29 16:24 ` Doug Evans
2008-01-29 16:37 ` Daniel Jacobowitz
2008-01-29 7:35 ` Joel Brobecker
2008-01-29 7:51 ` Pierre Muller
2008-01-29 13:46 ` Daniel Jacobowitz
2008-01-29 15:17 ` Pierre Muller
2008-01-29 16:25 ` 'Daniel Jacobowitz'
2008-01-29 16:04 ` Doug Evans
2008-01-29 16:34 ` Pierre Muller
2008-01-29 15:51 ` Doug Evans
2008-01-29 16:49 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129134609.GB22342@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox