From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8663 invoked by alias); 29 Jan 2008 13:46:31 -0000 Received: (qmail 8655 invoked by uid 22791); 29 Jan 2008 13:46:31 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 13:46:11 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 777AA9877C; Tue, 29 Jan 2008 13:46:10 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4D1E99839E; Tue, 29 Jan 2008 13:46:10 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JJqmv-0005vF-Av; Tue, 29 Jan 2008 08:46:09 -0500 Date: Tue, 29 Jan 2008 14:42:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: GDB Patches , Pierre Muller Subject: Re: [BUG] BINOP_DIV and ptyp command Message-ID: <20080129134609.GB22342@caradoc.them.org> Mail-Followup-To: Doug Evans , GDB Patches , Pierre Muller References: <002301c85c12$a73a4640$f5aed2c0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00675.txt.bz2 On Mon, Jan 28, 2008 at 09:34:48PM -0800, Doug Evans wrote: > On Jan 28, 2008 8:52 PM, Doug Evans wrote: > > [...] > > So it seems like the following is the correct patch. > > Well, not quite. Ok to check the appended patch in? > > Changing the expected result to long makes / and % no longer special - > x*y has an expected result of long. > > One can argue it should be int, but any fix for that is orthogonal to > fixing / and % handling. I think. If you had to change a testcase to a more wrong answer, then the bug isn't orthogonal :-) We should be following C promotion rules, and automatically promoting int math to long is incorrect. -- Daniel Jacobowitz CodeSourcery