Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Make mi_cmd_break_insert exception-safe.
Date: Mon, 28 Jan 2008 08:22:00 -0000	[thread overview]
Message-ID: <200801280718.23464.vladimir@codesourcery.com> (raw)
In-Reply-To: <18332.62269.25839.287045@kahikatea.snap.net.nz>

On Monday 28 January 2008 00:10:21 Nick Roberts wrote:
>  > The attached patch make mi_cmd_break_insert exception-safe, so that it always
>  > resets the hook it installs. There's new testcase that fails before the
>  > patch, and works after. OK?
> 
> Is this patch is on top of your earlier one?  

Yes.

> If so, I think that has to be 
> approved before we can review this one.  In fact there appear to be many
> changes in the pipeline that need to be resolved before the next release.
> 
>  > - Volodya
>  > 
>  > 	[gdb]
>  > 	* breakpoint.c (break_command_1): Return void.
>                                           ^^^^^^^^^^^
> That's a contradiction in terms, isn't it?

Not sure. C++ allows 

	return <expression-of-type-void>;

I suspect modern C allows as well, so terminologically,
this is fine.

- Volodya


  reply	other threads:[~2008-01-28  4:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 17:22 Vladimir Prus
2008-01-27 21:29 ` Nick Roberts
2008-01-28  8:22   ` Vladimir Prus [this message]
2008-01-28 14:29     ` Nick Roberts
2008-01-31 22:27 ` Daniel Jacobowitz
2008-02-01  6:54   ` Vladimir Prus
2008-02-01 14:25     ` Daniel Jacobowitz
2008-02-01 14:50       ` Vladimir Prus
2008-02-01 15:09         ` Daniel Jacobowitz
2008-02-01 15:46         ` Doug Evans
2008-02-01 16:16           ` Vladimir Prus
2008-02-01 15:49   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801280718.23464.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox