From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10872 invoked by alias); 28 Jan 2008 04:18:34 -0000 Received: (qmail 10864 invoked by uid 22791); 28 Jan 2008 04:18:33 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jan 2008 04:18:16 +0000 Received: (qmail 23268 invoked from network); 28 Jan 2008 04:18:14 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Jan 2008 04:18:14 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [RFA] Make mi_cmd_break_insert exception-safe. Date: Mon, 28 Jan 2008 08:22:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200801271715.08542.vladimir@codesourcery.com> <18332.62269.25839.287045@kahikatea.snap.net.nz> In-Reply-To: <18332.62269.25839.287045@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801280718.23464.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00639.txt.bz2 On Monday 28 January 2008 00:10:21 Nick Roberts wrote: > > The attached patch make mi_cmd_break_insert exception-safe, so that it always > > resets the hook it installs. There's new testcase that fails before the > > patch, and works after. OK? > > Is this patch is on top of your earlier one? Yes. > If so, I think that has to be > approved before we can review this one. In fact there appear to be many > changes in the pipeline that need to be resolved before the next release. > > > - Volodya > > > > [gdb] > > * breakpoint.c (break_command_1): Return void. > ^^^^^^^^^^^ > That's a contradiction in terms, isn't it? Not sure. C++ allows return ; I suspect modern C allows as well, so terminologically, this is fine. - Volodya