From: Vladimir Prus <vladimir@codesourcery.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Rethrow exception properly.
Date: Sun, 27 Jan 2008 14:15:00 -0000 [thread overview]
Message-ID: <200801271052.46239.vladimir@codesourcery.com> (raw)
In-Reply-To: <18331.59896.89303.672856@kahikatea.snap.net.nz>
On Sunday 27 January 2008 05:18:32 Nick Roberts wrote:
> > Such rethrowing is just wrong -- if we fully delegate handling of
> > the error to our caller, we should just throw the original exception.
> >
> > The attached patch switches to using throw_exception and gets us
> > back to sane MI error message. OK?
>
> There is still the anomaly between break_command_really returning int and
> gdb_breakpoint returning enum gdb_rc. Currently it looks like the return value
> of break_command_1 is not used, so this could presumably be void. If the
> exception handling is all done in break_command_really perhaps we don't need
> the return value of gdb_breakpoint.
That's a topic of separate patch (which will fix yet another problem). This
patch fixes the first apparent issue.
- Volodya
next prev parent reply other threads:[~2008-01-27 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 2:19 Vladimir Prus
2008-01-27 7:53 ` Nick Roberts
2008-01-27 14:15 ` Vladimir Prus [this message]
2008-01-31 22:21 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801271052.46239.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox