From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21764 invoked by alias); 27 Jan 2008 07:53:00 -0000 Received: (qmail 21756 invoked by uid 22791); 27 Jan 2008 07:52:59 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 27 Jan 2008 07:52:42 +0000 Received: (qmail 11498 invoked from network); 27 Jan 2008 07:52:40 -0000 Received: from unknown (HELO 172.16.unknown.plus.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jan 2008 07:52:40 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: [RFA] Rethrow exception properly. Date: Sun, 27 Jan 2008 14:15:00 -0000 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: gdb-patches@sources.redhat.com References: <200801262257.36197.vladimir@codesourcery.com> <18331.59896.89303.672856@kahikatea.snap.net.nz> In-Reply-To: <18331.59896.89303.672856@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801271052.46239.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00632.txt.bz2 On Sunday 27 January 2008 05:18:32 Nick Roberts wrote: > > Such rethrowing is just wrong -- if we fully delegate handling of > > the error to our caller, we should just throw the original exception. > > > > The attached patch switches to using throw_exception and gets us > > back to sane MI error message. OK? > > There is still the anomaly between break_command_really returning int and > gdb_breakpoint returning enum gdb_rc. Currently it looks like the return value > of break_command_1 is not used, so this could presumably be void. If the > exception handling is all done in break_command_really perhaps we don't need > the return value of gdb_breakpoint. That's a topic of separate patch (which will fix yet another problem). This patch fixes the first apparent issue. - Volodya