From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: 'Eli Zaretskii' <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] Handle BINOP_INTDIV in valarith.c
Date: Thu, 24 Jan 2008 01:30:00 -0000 [thread overview]
Message-ID: <20080124013030.GD3979@adacore.com> (raw)
In-Reply-To: <001d01c85e1b$5e280c70$1a782550$@u-strasbg.fr>
Pierre,
You raised some valid points in your message. I got a code review
for free :) and I sincerly thank you for that. I'll look into
them as soon as I can.
> OK, I get the idea, but the problem is that this leads to lots of code
> copy...
For this part, we can extract out the code you would otherwise
duplicate and have the pascal_evaluate_subexp call it.
> I agree with you that writing a pascal specific evaluate_subexp()
> function is better that explicitly checking the language of the
> currently parsed expression, but my idea was really to have on the
> contrary something usable for other languages, and thus not inside
> pascal specific code...
I don't think that we'll have to give up on your suggestion to
share the code. As explained above, any code that needs to be shared
can be shared through a single function. Would it work?
--
Joel
next prev parent reply other threads:[~2008-01-24 1:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 14:14 Pierre Muller
2008-01-16 19:11 ` Eli Zaretskii
2008-01-21 10:45 ` Pierre Muller
2008-01-23 18:25 ` Joel Brobecker
2008-01-23 22:36 ` Pierre Muller
2008-01-23 23:09 ` Joel Brobecker
2008-01-23 23:55 ` Pierre Muller
2008-01-24 1:30 ` Joel Brobecker [this message]
2008-01-23 19:07 ` Tom Tromey
2008-01-23 23:00 ` Pierre Muller
2008-01-24 0:27 ` Tom Tromey
2008-01-17 11:58 ` Joel Brobecker
2008-01-17 12:04 ` Joel Brobecker
2008-01-18 16:27 ` Eli Zaretskii
2008-01-21 15:04 ` Pierre Muller
2008-01-25 13:07 ` [RFA] Handle BINOP_INTDIV in eval.c Pierre Muller
2008-01-30 1:01 ` Daniel Jacobowitz
2008-01-30 7:35 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124013030.GD3979@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox