From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [patch]: Replace DEPRECATED_STREQN
Date: Fri, 18 Jan 2008 08:56:00 -0000 [thread overview]
Message-ID: <200801180855.m0I8tPSJ000947@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <479064C0.9090402@de.ibm.com> (message from Markus Deuling on Fri, 18 Jan 2008 09:35:12 +0100)
> Date: Fri, 18 Jan 2008 09:35:12 +0100
> From: Markus Deuling <deuling@de.ibm.com>
>
> Hi,
>
> this patch replaces and removes DEPRECATED_STREQN. Testsuite showed
> no regressions.
>
> Is this ok to commit ?
If you fix the issue below:
> diff -urpN src/gdb/m2-exp.y dev/gdb/m2-exp.y
> --- src/gdb/m2-exp.y 2008-01-01 23:53:11.000000000 +0100
> +++ dev/gdb/m2-exp.y 2008-01-18 09:17:20.000000000 +0100
> @@ -845,7 +845,7 @@ yylex ()
>
> /* See if it is a special token of length 2 */
> for( i = 0 ; i < (int) (sizeof tokentab2 / sizeof tokentab2[0]) ; i++)
> - if(DEPRECATED_STREQN(tokentab2[i].name, tokstart, 2))
> + if( strncmp (tokentab2[i].name, tokstart, 2) == 0)
Space before the '(', not after.
> @@ -1076,12 +1077,12 @@ yylex ()
> else
> {
> /* Built-in BOOLEAN type. This is sort of a hack. */
> - if(DEPRECATED_STREQN(tokstart,"TRUE",4))
> + if( strncmp (tokstart, "TRUE", 4) == 0)
Likewise.
> {
> yylval.ulval = 1;
> return M2_TRUE;
> }
> - else if(DEPRECATED_STREQN(tokstart,"FALSE",5))
> + else if( strncmp (tokstart, "FALSE", 5) == 0)
And here too.
next prev parent reply other threads:[~2008-01-18 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 8:37 Markus Deuling
2008-01-18 8:56 ` Mark Kettenis [this message]
2008-01-18 9:15 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801180855.m0I8tPSJ000947@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox