From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53438-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3934 invoked by alias); 18 Jan 2008 08:56:08 -0000
Received: (qmail 3925 invoked by uid 22791); 18 Jan 2008 08:56:08 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 Jan 2008 08:55:50 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id m0I8tQHI025017; 	Fri, 18 Jan 2008 09:55:26 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0I8tPSJ000947; 	Fri, 18 Jan 2008 09:55:25 +0100 (CET)
Date: Fri, 18 Jan 2008 08:56:00 -0000
Message-Id: <200801180855.m0I8tPSJ000947@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
In-reply-to: <479064C0.9090402@de.ibm.com> (message from Markus Deuling on 	Fri, 18 Jan 2008 09:35:12 +0100)
Subject: Re: [patch]: Replace DEPRECATED_STREQN
References:  <479064C0.9090402@de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00470.txt.bz2

> Date: Fri, 18 Jan 2008 09:35:12 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> Hi,
> 
> this patch replaces and removes DEPRECATED_STREQN. Testsuite showed
> no regressions.
> 
> Is this ok to commit ? 

If you fix the issue below:

> diff -urpN src/gdb/m2-exp.y dev/gdb/m2-exp.y
> --- src/gdb/m2-exp.y	2008-01-01 23:53:11.000000000 +0100
> +++ dev/gdb/m2-exp.y	2008-01-18 09:17:20.000000000 +0100
> @@ -845,7 +845,7 @@ yylex ()
>  
>    /* See if it is a special token of length 2 */
>    for( i = 0 ; i < (int) (sizeof tokentab2 / sizeof tokentab2[0]) ; i++)
> -     if(DEPRECATED_STREQN(tokentab2[i].name, tokstart, 2))
> +     if( strncmp (tokentab2[i].name, tokstart, 2) == 0)

Space before the '(', not after.

> @@ -1076,12 +1077,12 @@ yylex ()
>      else
>      {
>         /* Built-in BOOLEAN type.  This is sort of a hack. */
> -       if(DEPRECATED_STREQN(tokstart,"TRUE",4))
> +       if( strncmp (tokstart, "TRUE", 4) == 0)

Likewise.

>         {
>  	  yylval.ulval = 1;
>  	  return M2_TRUE;
>         }
> -       else if(DEPRECATED_STREQN(tokstart,"FALSE",5))
> +       else if( strncmp (tokstart, "FALSE", 5) == 0)

And here too.