From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [patch] Remove all current_gdbarch's in mn10300
Date: Mon, 14 Jan 2008 14:10:00 -0000 [thread overview]
Message-ID: <200801141409.m0EE9W2l017003@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <47879ECA.4050002@de.ibm.com> from "Markus Deuling" at Jan 11, 2008 05:52:26 PM
Markus Deuling wrote:
> @@ -604,7 +606,7 @@ mn10300_analyze_prologue (struct frame_i
> - if (AM33_MODE == 2)
> + if (AM33_MODE (get_frame_arch (fi))== 2)
This is incorrect, as mn10300_analyze_prologue may be called
with a NULL fi value (from mn10300_skip_prologue). I guess
the right way would be to allow the caller to pass an explicit
gdbarch ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-01-14 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 16:54 Markus Deuling
2008-01-14 14:10 ` Ulrich Weigand [this message]
2008-01-15 5:07 ` Markus Deuling
2008-01-15 20:38 ` Ulrich Weigand
2008-01-16 4:58 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801141409.m0EE9W2l017003@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox