From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15672 invoked by alias); 14 Jan 2008 14:10:03 -0000 Received: (qmail 15627 invoked by uid 22791); 14 Jan 2008 14:10:02 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jan 2008 14:09:36 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id m0EE9XSa144836 for ; Mon, 14 Jan 2008 14:09:33 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0EE9XkA1482888 for ; Mon, 14 Jan 2008 15:09:33 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0EE9WQa017009 for ; Mon, 14 Jan 2008 15:09:33 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m0EE9W2l017003; Mon, 14 Jan 2008 15:09:32 +0100 Message-Id: <200801141409.m0EE9W2l017003@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 14 Jan 2008 15:09:32 +0100 Subject: Re: [patch] Remove all current_gdbarch's in mn10300 To: deuling@de.ibm.com (Markus Deuling) Date: Mon, 14 Jan 2008 14:10:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <47879ECA.4050002@de.ibm.com> from "Markus Deuling" at Jan 11, 2008 05:52:26 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00328.txt.bz2 Markus Deuling wrote: > @@ -604,7 +606,7 @@ mn10300_analyze_prologue (struct frame_i > - if (AM33_MODE == 2) > + if (AM33_MODE (get_frame_arch (fi))== 2) This is incorrect, as mn10300_analyze_prologue may be called with a NULL fi value (from mn10300_skip_prologue). I guess the right way would be to allow the caller to pass an explicit gdbarch ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com