Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: DFP build failure
Date: Wed, 09 Jan 2008 18:36:00 -0000	[thread overview]
Message-ID: <20080109183554.GA16920@caradoc.them.org> (raw)
In-Reply-To: <1199903445.15225.50.camel@localhost.localdomain>

On Wed, Jan 09, 2008 at 04:30:45PM -0200, Thiago Jung Bauermann wrote:
> Mmmm.... sorry about that. What do you think of the attached fix
> (dangerous question to ask!)?
> 
> DOUBLEST_PRINT_FORMAT is currently not used, so not a big deal to change
> it a bit.

OK, with changelog entry.  This matches the standard PRIx64 et al,
too.  Could you update DOUBLEST_SCAN_FORMAT to match?

> -  ret = asprintf (&buffer, "%.30Lg", value_as_double (from));
> +  ret = asprintf (&buffer, "%.30"DOUBLEST_PRINT_FORMAT, value_as_double (from));

Space between " and D.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-01-09 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 16:49 Daniel Jacobowitz
2008-01-09 18:31 ` Thiago Jung Bauermann
2008-01-09 18:36   ` Daniel Jacobowitz [this message]
2008-01-09 19:11     ` Thiago Jung Bauermann
2008-01-09 19:15       ` Daniel Jacobowitz
2008-01-09 19:28         ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109183554.GA16920@caradoc.them.org \
    --to=drow@false.org \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox