From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2440 invoked by alias); 9 Jan 2008 18:36:19 -0000 Received: (qmail 2431 invoked by uid 22791); 9 Jan 2008 18:36:19 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jan 2008 18:35:57 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A2FAF98223; Wed, 9 Jan 2008 18:35:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8C8A698216; Wed, 9 Jan 2008 18:35:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JCfmM-0004Pc-KN; Wed, 09 Jan 2008 13:35:54 -0500 Date: Wed, 09 Jan 2008 18:36:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org Subject: Re: DFP build failure Message-ID: <20080109183554.GA16920@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20080109164917.GA10333@caradoc.them.org> <1199903445.15225.50.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199903445.15225.50.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00200.txt.bz2 On Wed, Jan 09, 2008 at 04:30:45PM -0200, Thiago Jung Bauermann wrote: > Mmmm.... sorry about that. What do you think of the attached fix > (dangerous question to ask!)? > > DOUBLEST_PRINT_FORMAT is currently not used, so not a big deal to change > it a bit. OK, with changelog entry. This matches the standard PRIx64 et al, too. Could you update DOUBLEST_SCAN_FORMAT to match? > - ret = asprintf (&buffer, "%.30Lg", value_as_double (from)); > + ret = asprintf (&buffer, "%.30"DOUBLEST_PRINT_FORMAT, value_as_double (from)); Space between " and D. -- Daniel Jacobowitz CodeSourcery