From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] make handling of input path vs subfile path consistent
Date: Tue, 08 Jan 2008 20:22:00 -0000 [thread overview]
Message-ID: <20080108202156.GA6515@caradoc.them.org> (raw)
In-Reply-To: <e394668d0801051432t34e56abet795972d8cd688fe@mail.gmail.com>
On Sat, Jan 05, 2008 at 02:32:57PM -0800, Doug Evans wrote:
> Hi. There's something I don't understand. Why does start_subfile not
> prepend dirname to name if the latter is not absolute? Since
> name,dirname are added to the subfile list if there isn't a match and
> then will later be used to do matches, it seems like we want to
> prepend dirname to the input name before doing FILENAME_CMP.
>
> Am I missing something?
I could only come up with one case to worry about: what if
subfile->dirname plus subfile->name produces a relative path that
would previously have matched the NAME argument? But dwarf2read.c
always passes the compilation directory (which we assume to be an
absolute path) as the dirname argument, so presumably the result of
combining subfile->dirname and subfile->name will be an absolute path
too.
Your patch is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-08 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 22:33 Doug Evans
2008-01-08 20:22 ` Daniel Jacobowitz [this message]
2008-01-06 5:45 Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108202156.GA6515@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox