From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4399 invoked by alias); 8 Jan 2008 20:22:23 -0000 Received: (qmail 4391 invoked by uid 22791); 8 Jan 2008 20:22:22 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 20:21:59 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A378C98216; Tue, 8 Jan 2008 20:21:57 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 84FDF98022; Tue, 8 Jan 2008 20:21:57 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1JCKxQ-0001sy-Jq; Tue, 08 Jan 2008 15:21:56 -0500 Date: Tue, 08 Jan 2008 20:22:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFC] make handling of input path vs subfile path consistent Message-ID: <20080108202156.GA6515@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00156.txt.bz2 On Sat, Jan 05, 2008 at 02:32:57PM -0800, Doug Evans wrote: > Hi. There's something I don't understand. Why does start_subfile not > prepend dirname to name if the latter is not absolute? Since > name,dirname are added to the subfile list if there isn't a match and > then will later be used to do matches, it seems like we want to > prepend dirname to the input name before doing FILENAME_CMP. > > Am I missing something? I could only come up with one case to worry about: what if subfile->dirname plus subfile->name produces a relative path that would previously have matched the NAME argument? But dwarf2read.c always passes the compilation directory (which we assume to be an absolute path) as the dirname argument, so presumably the result of combining subfile->dirname and subfile->name will be an absolute path too. Your patch is OK. -- Daniel Jacobowitz CodeSourcery