Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] fix indentation in dbxread.c
@ 2008-01-08 17:01 Doug Evans
  2008-01-08 17:05 ` Joel Brobecker
  2008-01-08 17:07 ` Daniel Jacobowitz
  0 siblings, 2 replies; 4+ messages in thread
From: Doug Evans @ 2008-01-08 17:01 UTC (permalink / raw)
  To: gdb-patches

Ok to check in?  These `if's are hard to read.

And for future reference, is it OK if these are just fixed and reported under
the "obvious" rule?

2008-01-08  Doug Evans  <dje@google.com>

	* dbxread.c (read_dbx_symtab): Fix indentation.

Index: dbxread.c
===================================================================
RCS file: /cvs/src/src/gdb/dbxread.c,v
retrieving revision 1.90
diff -u -p -u -p -r1.90 dbxread.c
--- dbxread.c	19 Oct 2007 12:26:31 -0000	1.90
+++ dbxread.c	8 Jan 2008 16:50:03 -0000
@@ -1551,7 +1551,7 @@ read_dbx_symtab (struct objfile *objfile
 	    if (tmp_language != language_unknown
 		&& (tmp_language != language_c
 		    || psymtab_language != language_cplus))
-	    psymtab_language = tmp_language;
+	      psymtab_language = tmp_language;
 
 	    if (pst == NULL)
 	    {
@@ -1584,7 +1584,7 @@ read_dbx_symtab (struct objfile *objfile
 	    if (tmp_language != language_unknown
 		&& (tmp_language != language_c
 		    || psymtab_language != language_cplus))
-	    psymtab_language = tmp_language;
+	      psymtab_language = tmp_language;
 
 	    /* In C++, one may expect the same filename to come round many
 	       times, when code is coming alternately from the main file


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] fix indentation in dbxread.c
  2008-01-08 17:01 [RFA] fix indentation in dbxread.c Doug Evans
@ 2008-01-08 17:05 ` Joel Brobecker
  2008-01-08 17:16   ` Doug Evans
  2008-01-08 17:07 ` Daniel Jacobowitz
  1 sibling, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2008-01-08 17:05 UTC (permalink / raw)
  To: Doug Evans; +Cc: gdb-patches


> 2008-01-08  Doug Evans  <dje@google.com>
> 
> 	* dbxread.c (read_dbx_symtab): Fix indentation.

Indeed, this is OK.

> And for future reference, is it OK if these are just fixed and
> reported under the "obvious" rule?

Formatting-only patches can indeed be treated as obvious.

Thanks,
-- 
Joel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] fix indentation in dbxread.c
  2008-01-08 17:01 [RFA] fix indentation in dbxread.c Doug Evans
  2008-01-08 17:05 ` Joel Brobecker
@ 2008-01-08 17:07 ` Daniel Jacobowitz
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2008-01-08 17:07 UTC (permalink / raw)
  To: Doug Evans; +Cc: gdb-patches

On Tue, Jan 08, 2008 at 09:00:52AM -0800, Doug Evans wrote:
> Ok to check in?  These `if's are hard to read.
> 
> And for future reference, is it OK if these are just fixed and reported under
> the "obvious" rule?

Yes, and yes.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] fix indentation in dbxread.c
  2008-01-08 17:05 ` Joel Brobecker
@ 2008-01-08 17:16   ` Doug Evans
  0 siblings, 0 replies; 4+ messages in thread
From: Doug Evans @ 2008-01-08 17:16 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On Jan 8, 2008 9:05 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>
> > 2008-01-08  Doug Evans  <dje@google.com>
> >
> >       * dbxread.c (read_dbx_symtab): Fix indentation.
>
> Indeed, this is OK.
>
> > And for future reference, is it OK if these are just fixed and
> > reported under the "obvious" rule?
>
> Formatting-only patches can indeed be treated as obvious.

Checked in.  Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-01-08 17:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-08 17:01 [RFA] fix indentation in dbxread.c Doug Evans
2008-01-08 17:05 ` Joel Brobecker
2008-01-08 17:16   ` Doug Evans
2008-01-08 17:07 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox