* [commit/Ada] Allow "{TYPE} ADDR" expression on left hand side of assignment
@ 2008-01-04 20:11 Joel Brobecker
2008-01-04 20:21 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2008-01-04 20:11 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Hello,
This patch allows the Ada-specific "{TYPE_NAME} ADDR" syntax to
be on the left hand side of an assignement. Before the patch,
the parser would error out saying:
(gdb) set {Integer} $addr := 19
Error in expression, near ` 19'.
2008-01-04 Paul N. Hilfinger <hilfinger@adacore.com>
* ada-exp.y: Allow '{type} ADDRESS' notation on left of assignment.
With a new testcase:
2008-01-04 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/type_coercion/ident.adb, gdb.ada/type_coercion/assign.adb:
New files.
* gdb.ada/type_coercion.exp: New testcase.
Tested on x86-linux, no regression. Checked in.
--
Joel
[-- Attachment #2: type_coercion.diff --]
[-- Type: text/plain, Size: 360 bytes --]
Index: ada-exp.y
===================================================================
--- ada-exp.y (revision 75)
+++ ada-exp.y (revision 76)
@@ -353,7 +353,7 @@ arglist : exp
{ $$ = $1 + 1; }
;
-simple_exp : '{' var_or_type '}' simple_exp %prec '.'
+primary : '{' var_or_type '}' primary %prec '.'
/* GDB extension */
{
if ($2 == NULL)
[-- Attachment #3: type_coercion-tc.diff --]
[-- Type: text/plain, Size: 4101 bytes --]
Index: gdb.ada/type_coercion.exp
===================================================================
--- gdb.ada/type_coercion.exp (revision 0)
+++ gdb.ada/type_coercion.exp (revision 77)
@@ -0,0 +1,63 @@
+# Copyright 2008 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if $tracelevel then {
+ strace $tracelevel
+}
+
+load_lib "ada.exp"
+
+set testdir "type_coercion"
+set testfile "${testdir}/assign"
+set srcfile ${srcdir}/${subdir}/${testfile}.adb
+set binfile ${objdir}/${subdir}/${testfile}
+
+file mkdir ${objdir}/${subdir}/${testdir}
+if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != "" } {
+ return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+set bp_location [gdb_get_line_number "START" ${testdir}/assign.adb]
+runto "assign.adb:$bp_location"
+
+gdb_test "p q" \
+ "\\(2, 3, 5, 7, 11\\)" \
+ "p q"
+
+gdb_test "set \$addr := q'address" \
+ "" \
+ "save q'address in convenience variable"
+
+gdb_test "p {Integer} \$addr" \
+ "2" \
+ "print {Integer} \$addr"
+
+# Now change the value at $addr using the same "{TYPE}" syntax.
+
+gdb_test "set {Integer} \$addr := 19" \
+ "" \
+ "set {Integer} \$addr := 19"
+
+gdb_test "p q" \
+ "\\(19, 3, 5, 7, 11\\)" \
+ "p q"
+
+
+
Index: gdb.ada/type_coercion/ident.adb
===================================================================
--- gdb.ada/type_coercion/ident.adb (revision 0)
+++ gdb.ada/type_coercion/ident.adb (revision 77)
@@ -0,0 +1,19 @@
+-- Copyright 2008 Free Software Foundation, Inc.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 3 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+-- You should have received a copy of the GNU General Public License
+-- along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+function Ident (X : Integer) return Integer is
+begin
+ return X;
+end Ident;
Index: gdb.ada/type_coercion/assign.adb
===================================================================
--- gdb.ada/type_coercion/assign.adb (revision 0)
+++ gdb.ada/type_coercion/assign.adb (revision 77)
@@ -0,0 +1,25 @@
+-- Copyright 2008 Free Software Foundation, Inc.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 3 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+-- You should have received a copy of the GNU General Public License
+-- along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+with Ident;
+procedure Assign is
+
+ Q: array (1..5) of Integer := (2, 3, 5, 7, 11);
+
+begin
+
+ Q(1) := Ident (Q(3)); -- START
+
+end Assign;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-04 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-04 20:11 [commit/Ada] Allow "{TYPE} ADDR" expression on left hand side of assignment Joel Brobecker
2008-01-04 20:21 ` Daniel Jacobowitz
2008-01-04 20:57 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox