From: msnyder@sonic.net
To: "Jim Blandy" <jimb@codesourcery.com>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [patch] target_read_string, potential memory leak.
Date: Wed, 08 Aug 2007 22:03:00 -0000 [thread overview]
Message-ID: <20077.12.7.175.2.1186610592.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <m3tzr9u29c.fsf@codesourcery.com>
>
> msnyder@sonic.net writes:
>>> msnyder@sonic.net writes:
>>>> OK -- it would be pretty stupid to call target_read_string without
>>>> passing it a buffer, but if we're going to check it for null...
>>>
>>> I don't think the contract for target_read_string permits STRING to be
>>> null. I think either the test should go, or we should add a
>>> gdb_assert (string).
>>
>> Agreed. Thus?
>
> Agreed, thus. :)
Committed. Fiat.
prev parent reply other threads:[~2007-08-08 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 3:29 msnyder
2007-08-06 22:30 ` Jim Blandy
2007-08-08 18:32 ` msnyder
2007-08-08 21:48 ` Jim Blandy
2007-08-08 22:03 ` msnyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20077.12.7.175.2.1186610592.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox