From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Subject: [patch] target_read_string, potential memory leak.
Date: Sun, 05 Aug 2007 03:29:00 -0000 [thread overview]
Message-ID: <13153.12.7.175.2.1186284546.squirrel@webmail.sonic.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 132 bytes --]
OK -- it would be pretty stupid to call target_read_string without
passing it a buffer, but if we're going to check it for null...
[-- Attachment #2: 137.txt --]
[-- Type: text/plain, Size: 567 bytes --]
2007-08-04 Michael Snyder <msnyder@access-company.com>
* target.c (target_read_string): Potential memory leak.
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.145
diff -p -r1.145 target.c
*** target.c 24 Jul 2007 12:49:24 -0000 1.145
--- target.c 5 Aug 2007 03:25:25 -0000
*************** done:
*** 972,977 ****
--- 972,980 ----
*errnop = errcode;
if (string != NULL)
*string = buffer;
+ else
+ xfree (buffer);
+
return nbytes_read;
}
next reply other threads:[~2007-08-05 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 3:29 msnyder [this message]
2007-08-06 22:30 ` Jim Blandy
2007-08-08 18:32 ` msnyder
2007-08-08 21:48 ` Jim Blandy
2007-08-08 22:03 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13153.12.7.175.2.1186284546.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox