Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb-patches@sourceware.org
Subject: Re: [i386/stabs] Arguments of main on gcc >= 4.1
Date: Sat, 29 Dec 2007 03:42:00 -0000	[thread overview]
Message-ID: <20071229033659.GA30002@adacore.com> (raw)
In-Reply-To: <47756D52.7010208@portugalmail.pt>

> gcc 3.4.4 doesn't emit the stack-alignment code.  Unless
> the comments in i386-tdep.c are wrong, any gcc < 4.1 doesn't emit
> the stack-alignment code, which makes them immune to the patch.
> I did regtest the patch on Cygwin.

That's good to know.

> >The fact that this has nobody before you reported that this is
> >broken since 4.1 shows that this is probably not an extremely
> >important issue. 
> 
> I've seen this reported at the mingw-users@ list with the
> new gcc4.2 binaries.  As you know, mingw support wasn't in the
> FSF tree, so problems seen on mingw weren't being reported here.
> 
> But sure, this isn't certainly my priority ;-)

Just to be clear, I didn't mean to brush off the patch. What I meant
was that, if we break compatibility with old compilers, it isn't
going to be extremely damaging (given that other people have lived
with the same problem for so long already).

> Even if gcc debug info isn't fixed, there will be several gcc
> releases with the problem and (pending confirmation), no
> release with stack alignment without the problem.

The problem if they fix GCC is that we would then have to support
both conventions. If we can't auto-detect, then perhaps we'll have
to introduce a set command. Ugh :-(.

> I'll try to break the patch further -- the setup for the
> workaround is mostly bugfixing, and I'll come back to the
> workaround later on if I'm still using a stabs outputting
> compiler by then :-)

I definitely recommend DWARF. We have been using DWARF on Windows
for a couple of years, I think and it works great!

-- 
Joel


  reply	other threads:[~2007-12-29  3:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 16:40 Pedro Alves
2007-12-03 18:25 ` Joel Brobecker
2007-12-17  0:47   ` Daniel Jacobowitz
2007-12-17  6:42     ` Joel Brobecker
2007-12-17 13:33       ` Daniel Jacobowitz
2007-12-17 15:06         ` Joel Brobecker
2007-12-28  1:20           ` Pedro Alves
2007-12-28 14:31             ` Joel Brobecker
2007-12-28 22:36               ` Pedro Alves
2007-12-29  3:42                 ` Joel Brobecker [this message]
2007-12-30  4:38             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071229033659.GA30002@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro_alves@portugalmail.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox