From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24730 invoked by alias); 29 Dec 2007 03:37:20 -0000 Received: (qmail 24721 invoked by uid 22791); 29 Dec 2007 03:37:19 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 29 Dec 2007 03:37:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C63772A963E; Fri, 28 Dec 2007 22:37:07 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ivfz+Gh9tf1C; Fri, 28 Dec 2007 22:37:07 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E3FBB2A963B; Fri, 28 Dec 2007 22:37:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B3B3636A4A3; Sat, 29 Dec 2007 07:36:59 +0400 (RET) Date: Sat, 29 Dec 2007 03:42:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [i386/stabs] Arguments of main on gcc >= 4.1 Message-ID: <20071229033659.GA30002@adacore.com> References: <47503C57.6010308@portugalmail.pt> <20071203182540.GB14306@adacore.com> <20071217004444.GA14356@caradoc.them.org> <20071217041159.GB9022@adacore.com> <20071217133121.GA23586@caradoc.them.org> <20071217142204.GI9022@adacore.com> <47744F3A.50005@portugalmail.pt> <20071228132203.GF24450@adacore.com> <47756D52.7010208@portugalmail.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47756D52.7010208@portugalmail.pt> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00442.txt.bz2 > gcc 3.4.4 doesn't emit the stack-alignment code. Unless > the comments in i386-tdep.c are wrong, any gcc < 4.1 doesn't emit > the stack-alignment code, which makes them immune to the patch. > I did regtest the patch on Cygwin. That's good to know. > >The fact that this has nobody before you reported that this is > >broken since 4.1 shows that this is probably not an extremely > >important issue. > > I've seen this reported at the mingw-users@ list with the > new gcc4.2 binaries. As you know, mingw support wasn't in the > FSF tree, so problems seen on mingw weren't being reported here. > > But sure, this isn't certainly my priority ;-) Just to be clear, I didn't mean to brush off the patch. What I meant was that, if we break compatibility with old compilers, it isn't going to be extremely damaging (given that other people have lived with the same problem for so long already). > Even if gcc debug info isn't fixed, there will be several gcc > releases with the problem and (pending confirmation), no > release with stack alignment without the problem. The problem if they fix GCC is that we would then have to support both conventions. If we can't auto-detect, then perhaps we'll have to introduce a set command. Ugh :-(. > I'll try to break the patch further -- the setup for the > workaround is mostly bugfixing, and I'll come back to the > workaround later on if I'm still using a stabs outputting > compiler by then :-) I definitely recommend DWARF. We have been using DWARF on Windows for a couple of years, I think and it works great! -- Joel