[commit/testcase/Ada] character parameter handling in inferior funcall

[commit/testcase/Ada] character parameter handling in inferior funcall

[Joel Brobecker]

Hello,

As promised in:
  http://www.sourceware.org/ml/gdb-patches/2007-12/msg00405.html.

Here is an Ada testcase that checks that character parameters are
properly passed when making an inferior function call.

2007-12-24  Joel Brobecker  <brobecker@adacore.com>

        * gdb.ada/char_param/pck.ads, gdb.ada/char_param/pck.adb,
        gdb.ada/char_param/foo.adb: New files.
        * gdb.ada/char_param.exp: New testcase.

Tested on x86-linux. It was a pretty simple testcase, so I felt
sufficiently confident to check it in.  Comments more than welcome,
however.

Now I'll use that testcase on other targets, to see if all goes well.
I suspect amd64 might be failing for instance...

Cheers,
-- 
Joel

Re: [commit/testcase/Ada] character parameter handling in inferior funcall

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

> 2007-12-24  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb.ada/char_param/pck.ads, gdb.ada/char_param/pck.adb,
>         gdb.ada/char_param/foo.adb: New files.
>         * gdb.ada/char_param.exp: New testcase.

ENOPATCH...  Now attached.

-- 
Joel

[-- Attachment #2: pck.ads --]
[-- Type: text/plain, Size: 1039 bytes --]

--  Copyright 2007 Free Software Foundation, Inc.
--
--  This program is free software; you can redistribute it and/or modify
--  it under the terms of the GNU General Public License as published by
--  the Free Software Foundation; either version 3 of the License, or
--  (at your option) any later version.
--
--  This program is distributed in the hope that it will be useful,
--  but WITHOUT ANY WARRANTY; without even the implied warranty of
--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
--  GNU General Public License for more details.
--
--  You should have received a copy of the GNU General Public License
--  along with this program.  If not, see <http://www.gnu.org/licenses/>.

with System;

package Pck is

   Procedure_Result : Character := ' ';

   procedure Same (C : Character);
   --  Set Procedure_Result to C.

   procedure Next (C : in out Character);
   --  Increment C (if C is the last character, then set C to the first
   --  character).  Set Procedure_Result to the new value of C.

end Pck;

[-- Attachment #3: pck.adb --]
[-- Type: text/plain, Size: 1048 bytes --]

--  Copyright 2007 Free Software Foundation, Inc.
--
--  This program is free software; you can redistribute it and/or modify
--  it under the terms of the GNU General Public License as published by
--  the Free Software Foundation; either version 3 of the License, or
--  (at your option) any later version.
--
--  This program is distributed in the hope that it will be useful,
--  but WITHOUT ANY WARRANTY; without even the implied warranty of
--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
--  GNU General Public License for more details.
--
--  You should have received a copy of the GNU General Public License
--  along with this program.  If not, see <http://www.gnu.org/licenses/>.

package body Pck is

   procedure Same (C : Character) is
   begin
      Procedure_Result := C;
   end Same;

   procedure Next (C : in out Character) is
   begin
      if C = Character'Last then
         C := Character'First;
      else
         C := Character'Succ (C);
      end if;
      Procedure_Result := C;
   end Next;

end Pck;

[-- Attachment #4: foo.adb --]
[-- Type: text/plain, Size: 865 bytes --]

--  Copyright 2007 Free Software Foundation, Inc.
--
--  This program is free software; you can redistribute it and/or modify
--  it under the terms of the GNU General Public License as published by
--  the Free Software Foundation; either version 3 of the License, or
--  (at your option) any later version.
--
--  This program is distributed in the hope that it will be useful,
--  but WITHOUT ANY WARRANTY; without even the implied warranty of
--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
--  GNU General Public License for more details.
--
--  You should have received a copy of the GNU General Public License
--  along with this program.  If not, see <http://www.gnu.org/licenses/>.

with Pck; use Pck;

procedure Foo is
   First : Character := 'a';
begin
   Procedure_Result := ' ';
   Same (First);  -- STOP
   Next (First);
end Foo;




[-- Attachment #5: char_param.exp --]
[-- Type: text/plain, Size: 1928 bytes --]

# Copyright 2007 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

if $tracelevel then {
    strace $tracelevel
}

load_lib "ada.exp"

set testdir "char_param"
set testfile "${testdir}/foo"
set srcfile ${srcdir}/${subdir}/${testfile}.adb
set binfile ${objdir}/${subdir}/${testfile}

file mkdir ${objdir}/${subdir}/${testdir}
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnata ]] != "" } {
  return -1
}

gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}

set bp_location [gdb_get_line_number "STOP" ${testdir}/foo.adb]
runto "foo.adb:$bp_location"

# Call same and next which are procedures that take a Character
# as a parameter.  To verify that the call was performed correctly,
# we check the value of "Procedure_Result" which is set during
# the function call.

gdb_test "print procedure_result" \
         "32 ' '"  \
         "print procedure_result before calling same"

gdb_test "call same (first)" \
         "" \
         "call same"

gdb_test "print procedure_result" \
         "97 'a'"  \
         "print procedure_result after calling same"

gdb_test "call next (first)" \
         "98 'b'" \
         "call next"

gdb_test "print procedure_result" \
         "98 'b'"  \
         "print procedure_result after calling next"