Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] continue stepping if landed in new range of same line
Date: Sat, 22 Dec 2007 18:05:00 -0000	[thread overview]
Message-ID: <20071222173903.GA22038@caradoc.them.org> (raw)
In-Reply-To: <20071222060137.GS6154@adacore.com>

On Sat, Dec 22, 2007 at 10:01:37AM +0400, Joel Brobecker wrote:
> I wouldn't mind removing the code altogether; as a bonus it would also
> reduce the size of handle_inferior_event. I can send a patch now, or
> I can poll users on gdb@ and see what they think... Honestly, given
> the likeliness of one-line functions, I'd just say it's not very
> important to keep that special case.

There are a few one line functions in the testsuite.  In my opinion /
experience, they cover all the cases that really need to be covered;
if we find an omission, we can add some more tests :-)

> 2007-12-22  Joel Brobecker  <brobecker@adacore.com>
> 
>         * infrun.c (handle_inferior_event): Remove code that made us
>         stop when stepping into the last line of the current function.
> 
> Tested on x86-linux, no regression.

This is OK as far as I'm concerned.  And I am always in favor of
simplifying handle_inferior_event.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-12-22 17:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19 12:59 Joel Brobecker
2007-12-19 14:18 ` Daniel Jacobowitz
2007-12-20  5:40   ` Joel Brobecker
2007-12-20 14:08     ` Daniel Jacobowitz
2007-12-21  6:28       ` Joel Brobecker
2007-12-21 14:01         ` Daniel Jacobowitz
2007-12-22  6:03           ` Joel Brobecker
2007-12-22 18:05             ` Daniel Jacobowitz [this message]
2007-12-24  6:41               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071222173903.GA22038@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox